-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mecanum drive controller adding and ported to ros2 #4
Conversation
mecanum_drive_controller/test/test_mecanum_drive_controller.hpp
Outdated
Show resolved
Hide resolved
mecanum_drive_controller/test/test_mecanum_drive_controller.hpp
Outdated
Show resolved
Hide resolved
mecanum_drive_controller/test/test_mecanum_drive_controller_preceeding.cpp
Outdated
Show resolved
Hide resolved
mecanum_drive_controller/test/test_mecanum_drive_controller.hpp
Outdated
Show resolved
Hide resolved
general changes not any fundamental changes Co-authored-by: Denis Štogl <denis@stoglrobotics.de>
using std instead of boost Co-authored-by: Denis Štogl <denis@stoglrobotics.de>
re-positioned controller_state_publisher_->unlock(); Co-authored-by: Denis Štogl <denis@stoglrobotics.de>
mecanum_drive_controller/include/mecanum_drive_controller/mecanum_drive_controller.hpp
Outdated
Show resolved
Hide resolved
mecanum_drive_controller/include/mecanum_drive_controller/odometry.hpp
Outdated
Show resolved
Hide resolved
mecanum_drive_controller/include/mecanum_drive_controller/odometry.hpp
Outdated
Show resolved
Hide resolved
mecanum_drive_controller/test/test_mecanum_drive_controller.cpp
Outdated
Show resolved
Hide resolved
mecanum_drive_controller/test/test_mecanum_drive_controller.cpp
Outdated
Show resolved
Hide resolved
mecanum_drive_controller/test/test_mecanum_drive_controller.cpp
Outdated
Show resolved
Hide resolved
mecanum_drive_controller/test/test_mecanum_drive_controller.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few important things for the future to makes reviews easier:
- always run pre-commit formatters before saying that something is ready for review
- If you get a comment about some pattern, that care that you apply it to all places with similar pattern. Usually, the reviews don't repeat their comments on each iteration of the same issue.
- Please review your code first before saying it is ready for the review:
- make sure there are not uncommended code blocks or if they have to be there add explanation why.
- resolve all TODOs or add qustion about them either in the code or in GitHub so that one know this is open for discussion
Co-authored-by: Dr. Denis <denis@stoglrobotics.de>
@@ -0,0 +1,112 @@ | |||
cmake_minimum_required(VERSION 3.8) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Robotgir please check that is change the same as ros-controls#510
Just to be fully aligned later.
mecanum_drive_controller/include/mecanum_drive_controller/mecanum_drive_controller.hpp
Outdated
Show resolved
Hide resolved
mecanum_drive_controller/include/mecanum_drive_controller/mecanum_drive_controller.hpp
Outdated
Show resolved
Hide resolved
mecanum_drive_controller/include/mecanum_drive_controller/odometry.hpp
Outdated
Show resolved
Hide resolved
double wz_b_b0_b_; // [rad/s] | ||
|
||
/// Wheels kinematic parameters [m]: | ||
double wheels_k_; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer if we would do direct use of this sum. Or we sum them before calculation. Or somehow rename this variable. This is confusing. Do you have ideas for better naming?
mecanum_drive_controller/test/mecanum_drive_controller_preceeding_params.yaml
Outdated
Show resolved
Hide resolved
mecanum_drive_controller/test/test_load_mecanum_drive_controller.cpp
Outdated
Show resolved
Hide resolved
mecanum_drive_controller/test/test_mecanum_drive_controller.cpp
Outdated
Show resolved
Hide resolved
mecanum_drive_controller/test/test_mecanum_drive_controller.hpp
Outdated
Show resolved
Hide resolved
mecanum_drive_controller/test/test_mecanum_drive_controller_preceeding.cpp
Outdated
Show resolved
Hide resolved
mecanum_drive_controller/include/mecanum_drive_controller/visibility_control.h
Outdated
Show resolved
Hide resolved
Moving to upstream PR |
No description provided.